Skip to content

feat: add reasoning trace extraction from llm calls #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

feat: add reasoning trace extraction from llm calls #1431

merged 2 commits into from
Oct 13, 2025

Conversation

Pouyanpi
Copy link
Collaborator

@Pouyanpi Pouyanpi commented Oct 1, 2025 •
edited
Loading

Stack Info

This PR is part of a stack:

  1. refactor!: drop reasoning trace extraction logic #1427
  2. feat: add reasoning trace extraction from llm calls #1431 (this PR)
  3. feat: emit BotThinking events with reasoning traces #1432
  4. feat(logging): improve event logging and add bot thinking display #1434

⚠️ Depends on: #1427

Description

add reasoning trace extraction from llm calls as we are using invoke and ainvoke in llm_call

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
nemoguardrails/actions/llm/utils.py 91.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Pouyanpi Pouyanpi added this to the v0.18.0 milestone Oct 2, 2025
This was referenced Oct 2, 2025
Merged
Merged
Merged
tgasser-nv
tgasser-nv approved these changes Oct 3, 2025
View reviewed changes
Copy link
Collaborator

@tgasser-nv tgasser-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question on the refactoring intent

Base automatically changed from refactor/reasoning-traces-langchain-integration to develop October 13, 2025 07:51
@Pouyanpi Pouyanpi force-pushed the feat/reasoning-trace-extraction-langchain branch from f621f9d to 80e3466 Compare October 13, 2025 07:53
@Pouyanpi Pouyanpi force-pushed the feat/reasoning-trace-extraction-langchain branch from 80e3466 to be7223e Compare October 13, 2025 07:59
@Pouyanpi Pouyanpi merged commit 3f546ae into develop Oct 13, 2025
7 checks passed
@Pouyanpi Pouyanpi deleted the feat/reasoning-trace-extraction-langchain branch October 13, 2025 08:09
tgasser-nv pushed a commit that referenced this pull request Oct 14, 2025
@Pouyanpi @tgasser-nv
feat(bot-thinking): add reasoning trace extraction from llm calls (#1431
596c24f 
)

* feat: add reasoning trace extraction from llm calls

* test(reasoning-trace): add comprehensive tests for additional_kwargs extraction
tgasser-nv pushed a commit that referenced this pull request Oct 14, 2025
@Pouyanpi @tgasser-nv
feat(bot-thinking): add reasoning trace extraction from llm calls (#1431
1d50230 
)

* feat: add reasoning trace extraction from llm calls

* test(reasoning-trace): add comprehensive tests for additional_kwargs extraction
tgasser-nv pushed a commit that referenced this pull request Oct 14, 2025
@Pouyanpi @tgasser-nv
feat(bot-thinking): add reasoning trace extraction from llm calls (#1431
8a94a99 
)

* feat: add reasoning trace extraction from llm calls

* test(reasoning-trace): add comprehensive tests for additional_kwargs extraction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgasser-nv tgasser-nv tgasser-nv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Pouyanpi @codecov-commenter @tgasser-nv